Tactile switch improvements

This commit is contained in:
Bane Stojkovic
2026-01-02 21:06:27 +01:00
parent 1f85c07453
commit 502a4b8d39
4 changed files with 124 additions and 7 deletions
@@ -501,6 +501,10 @@
<changeType>NEW_FEATURE</changeType>
<description>Configurable 'Tactile Micro Switch' dimensions and added a few most commonly used variants</description>
</org.diylc.appframework.update.Change>
<org.diylc.appframework.update.Change>
<changeType>NEW_FEATURE</changeType>
<description>Exposed the most common pin pairing modes and added switching logic for 'Tactile Micro Switch' to allow using it for analysis</description>
</org.diylc.appframework.update.Change>
<org.diylc.appframework.update.Change>
<changeType>BUG_FIX</changeType>
<description>Clicking on 'Tactile Micro Switch' body doesn't register</description>
@@ -35,13 +35,10 @@ import org.diylc.common.IPlugInPort;
import org.diylc.common.ObjectCache;
import org.diylc.common.Orientation;
import org.diylc.components.AbstractLabeledComponent;
import org.diylc.core.ComponentState;
import org.diylc.core.IDIYComponent;
import org.diylc.core.IDrawingObserver;
import org.diylc.core.Project;
import org.diylc.core.Theme;
import org.diylc.core.VisibilityPolicy;
import org.diylc.components.guitar.LeverSwitchPositionPropertyValueSource;
import org.diylc.core.*;
import org.diylc.core.annotations.ComponentDescriptor;
import org.diylc.core.annotations.DynamicEditableProperty;
import org.diylc.core.annotations.EditableProperty;
import org.diylc.core.annotations.KeywordPolicy;
import org.diylc.core.gerber.IGerberComponentSimple;
@@ -53,7 +50,8 @@ import org.diylc.utils.Constants;
category = "Electro-Mechanical", instanceNamePrefix = "SW",
description = "4-pin tactile momentary switch", zOrder = IDIYComponent.COMPONENT,
keywordPolicy = KeywordPolicy.SHOW_VALUE, enableCache = true)
public class TactileMicroSwitch extends AbstractLabeledComponent<String> implements IGerberComponentSimple {
public class TactileMicroSwitch extends AbstractLabeledComponent<String> implements IGerberComponentSimple,
ISwitch {
private static final long serialVersionUID = 1L;
@@ -82,6 +80,7 @@ public class TactileMicroSwitch extends AbstractLabeledComponent<String> impleme
private Size pinSpacing;
private Size rowSpacing;
private PinPairingMode pinPairingMode;
private int selectedPosition;
public TactileMicroSwitch() {
super();
@@ -476,6 +475,54 @@ public class TactileMicroSwitch extends AbstractLabeledComponent<String> impleme
maxY - minY + 2 * margin);
}
@Override
public int getPositionCount() {
return 2;
}
@Override
public String getPositionName(int position) {
return position == 0 ? "Released" : "Pressed";
}
@Override
public boolean arePointsConnected(int index1, int index2, int position) {
// Only connect pins when switch is pressed (position = 1)
if (position != 1) {
return false;
}
PinPairingMode mode = getPinPairingMode();
switch (mode) {
case Opposite:
// Pins on opposite sides (same row): 0-2 and 1-3
return (index1 == 0 && index2 == 2) || (index1 == 2 && index2 == 0) ||
(index1 == 1 && index2 == 3) || (index1 == 3 && index2 == 1);
case Diagonal:
// Diagonally opposite pins: 0-3 and 1-2
return (index1 == 0 && index2 == 3) || (index1 == 3 && index2 == 0) ||
(index1 == 1 && index2 == 2) || (index1 == 2 && index2 == 1);
case Adjacent:
// Pins next to each other (same column): 0-1 and 2-3
return (index1 == 0 && index2 == 1) || (index1 == 1 && index2 == 0) ||
(index1 == 2 && index2 == 3) || (index1 == 3 && index2 == 2);
default:
return false;
}
}
@DynamicEditableProperty(source = TactileMicroSwitchPositionPropertyValueSource.class)
@EditableProperty(name = "Selected Position")
@Override
public Integer getSelectedPosition() {
return selectedPosition;
}
public void setSelectedPosition(Integer selectedPosition) {
this.selectedPosition = selectedPosition;
}
public enum PinPairingMode {
Opposite, Diagonal, Adjacent;
}
@@ -0,0 +1,17 @@
package org.diylc.components.electromechanical;
import org.diylc.common.PropertyWrapper;
import org.diylc.components.guitar.LeverSwitch;
import org.diylc.core.AbstractDynamicPropertyValueSource;
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
public class TactileMicroSwitchPositionPropertyValueSource extends AbstractDynamicPropertyValueSource {
@Override
public List<Object> getAvailableValues() {
return List.of("Released", "Pressed");
}
}
@@ -0,0 +1,49 @@
package org.diylc.netlist;
import org.junit.Test;
import org.diylc.components.electromechanical.TactileMicroSwitch;
import org.diylc.components.electromechanical.TactileMicroSwitch.PinPairingMode;
public class TactileMicroSwitchTests extends AbstractSwitchTests {
@Test
public void testTactileMicroSwitchOpposite() {
TactileMicroSwitch tactileSwitch = new TactileMicroSwitch();
tactileSwitch.setPinPairingMode(PinPairingMode.Opposite);
// Position 0 (Released): no connections
// Position 1 (Pressed): pins on opposite sides (same row): 0-2 and 1-3
String[] validCombinations = new String[] {
"1,0,2", "1,2,0", // Position 1: 0-2 (both directions)
"1,1,3", "1,3,1" // Position 1: 1-3 (both directions)
};
testSwitch(tactileSwitch, validCombinations);
}
@Test
public void testTactileMicroSwitchDiagonal() {
TactileMicroSwitch tactileSwitch = new TactileMicroSwitch();
tactileSwitch.setPinPairingMode(PinPairingMode.Diagonal);
// Position 0 (Released): no connections
// Position 1 (Pressed): diagonally opposite pins: 0-3 and 1-2
String[] validCombinations = new String[] {
"1,0,3", "1,3,0", // Position 1: 0-3 (both directions)
"1,1,2", "1,2,1" // Position 1: 1-2 (both directions)
};
testSwitch(tactileSwitch, validCombinations);
}
@Test
public void testTactileMicroSwitchAdjacent() {
TactileMicroSwitch tactileSwitch = new TactileMicroSwitch();
tactileSwitch.setPinPairingMode(PinPairingMode.Adjacent);
// Position 0 (Released): no connections
// Position 1 (Pressed): pins next to each other (same column): 0-1 and 2-3
String[] validCombinations = new String[] {
"1,0,1", "1,1,0", // Position 1: 0-1 (both directions)
"1,2,3", "1,3,2" // Position 1: 2-3 (both directions)
};
testSwitch(tactileSwitch, validCombinations);
}
}